feat(core, postgres): Add RunFunctionWaitStrategy and use it in pg #908
+105
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankatins
force-pushed
the
feat/add-RunFunctionWaitStrategy-and-use-it-in-pg
branch
from
b4ea0ee to
d2b2200
Compare
jankatins
commented
Oct 18, 2025
| result = self.func(container) | ||
| if result: | ||
| return result | ||
| except tuple(self._transient_exceptions) as e: |
There was a problem hiding this comment.
I actually found no reason why this shouldn't be a tuple already on self -> might be an nice refactoring on WaitStrategy and where it's used.
jankatins
commented
Oct 18, 2025
| ] | ||
| ) | ||
| if result.exit_code: | ||
| raise ConnectionError("pg_isready is not ready yet") |
There was a problem hiding this comment.
I assume that the pg_isready is some missing change in an older commit. I haven't investigated more...
jankatins
commented
Oct 18, 2025
| return returns.pop(0) | ||
|
|
||
| strategy = RunFunctionWaitStrategy(func).with_poll_interval(0) | ||
| strategy.wait_until_ready(mock_container) # type: ignore[arg-type] |
There was a problem hiding this comment.
For some reason mypy didn't like passing in the mock and I had to add the ignore despite other places in the same file not having this problem with mock. No idea why :-(
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
==========================================
+ Coverage 79.78% 80.00% +0.21%
==========================================
Files 14 14
Lines 1182 1200 +18
Branches 184 186 +2
==========================================
+ Hits 943 960 +17
- Misses 197 199 +2
+ Partials 42 41 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is usefull for converting old wait_container_is_ready which use container.exec() to check for a condition to become True.
jankatins
force-pushed
the
feat/add-RunFunctionWaitStrategy-and-use-it-in-pg
branch
2 times, most recently
from
ca685b7 to
8c1e4f9
Compare
This gets rid of a annoying depcreation warning.
jankatins
force-pushed
the
feat/add-RunFunctionWaitStrategy-and-use-it-in-pg
branch
from
8c1e4f9 to
531934a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found no way to convert the current
container.exec()based check function to any of the currently existingWaitStartegiesand so I addedRunFunctionWaitStrategywhich can be used to convert suchcontainer.exec()based checks.Helps with: #874
Closes: #883